Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix type exports field for nitropack/runtime #2313

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 25, 2024

πŸ”— Linked issue

resolves #2277 also relevant to #2305

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

a current limitation of mkdist requires src to have explicit .mts and we were wrongly pointing types to nonexistent files.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 98395f7 into main Mar 25, 2024
5 checks passed
@pi0 pi0 deleted the build-runtime branch March 25, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing .d.mts files in /dist/runtime folder
1 participant